#1441: Fix issues with WordOccurenceAccumulator on Windows.
#1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 25, 2017 18:00
…ction by passing explicit `offset` parameter.
macks22
referenced
this pull request
Jun 26, 2017
Fix numpy/scipy version & disable nnz code from nose (temporary option)
|
Great @macks22, thank you for PR 👍 |
saparina
pushed a commit
to saparina/gensim
that referenced
this pull request
Jul 9, 2017
(piskvorky#1449) * piskvorky#1441: Fix issues with `WordOccurenceAccumulator` on Windows. * piskvorky#1441: Use pre-scipy0.17 version of `scipy.sparse.diags` function by passing explicit `offset` parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve the first part of #1441.
For some reason, the "view" of the numpy array
_uniq_wordswas not being updated on Windows, so I just rebuilt it each time it needed to be used instead of caching it once on init. If anyone can suggest an alternative approach that avoids this, I think that might be a more optimal solution. However, I doubt this added overhead is significant.