Add __getitem__ method to Sparse2Corpus to allow direct queries #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piskvorky
requested changes
Oct 10, 2017
gensim/matutils.py
Outdated
| @@ -342,6 +342,11 @@ def __iter__(self): | |||
| def __len__(self): | |||
| return self.sparse.shape[1] | |||
|
|
|||
| def __getitem__(self, item): | |||
There was a problem hiding this comment.
What is item? Row index, column index, something else?
Missing docstring (method semantics, args, returns).
menshikh-iv
suggested changes
Oct 11, 2017
There was a problem hiding this comment.
Docstring in Numpy style please, guide - https://github.com/numpy/numpy/blob/master/doc/HOWTO_DOCUMENT.rst.txt
P/S Don't forget to pull your branch first, because I fixed PEP8 mistake in your code
menshikh-iv
approved these changes
Oct 12, 2017
|
Thank you @isamaru, congratz with first PR 👍 |
horpto
pushed a commit
to horpto/gensim
that referenced
this pull request
Oct 28, 2017
…vorky#1621) * Add __getitem__ method to Sparse2Corpus to allow direct queries * Fix PEP8 * Add docstring for Sparse2Corpus.__getitem__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@piskvorky @janpom @menshikh-iv
Adds
__getitem__method to Sparse2Corpus to enable direct doc querying.Was necessary so that the CSC corpus could be used for similarity computation, and looks overall useful.