Fixed incompatability in persistence for older versions #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @chinmayapancholi13, good work 👍 |
piskvorky
reviewed
Nov 20, 2017
| def load(cls, *args, **kwargs): | ||
| model = super(FastText, cls).load(*args, **kwargs) | ||
| if hasattr(model.wv, 'syn0_all'): | ||
| setattr(model.wv, 'syn0_ngrams', model.wv.syn0_all) |
There was a problem hiding this comment.
What's with this setattr / delattr? Why not a simple (and more readable) model.wv.syn0_ngrams = model.wv.syn0_all?
| self.assertEqual(loaded_model.wv.syn0.shape[1], 10) | ||
| self.assertEqual(loaded_model.wv.syn0_ngrams.shape[1], 10) | ||
| # in-vocab word | ||
| in_expected_vec = numpy.array([-2.44566941, -1.54802394, -2.61103821, -1.88549316, 1.02860415, |
There was a problem hiding this comment.
Bad indentation (please use hanging indent).
| 1.19031894, 2.01627707, 1.98942184, -1.39095843, -0.65036952]) | ||
| self.assertTrue(numpy.allclose(loaded_model["the"], in_expected_vec, atol=1e-4)) | ||
| # out-of-vocab word | ||
| out_expected_vec = numpy.array([-1.34948218, -0.8686831, -1.51483142, -1.0164026, 0.56272298, |
VaiyeBe
pushed a commit
to VaiyeBe/gensim
that referenced
this pull request
Nov 26, 2017
…1642 (piskvorky#1723) * added 'load' method for fasttext wrapper * added unit-test for persistence with pre-3.0.0 models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
loadmethod to classgensim.models.wrappers.fasttext.FastTextto setself.wv.syn0_ngrams(present in newer models) usingself.wv.syn0_all(present in older models).Relevant issue : #1642
cc : @Liebeck