Fix os.rename from gensim.downloader when src and dst on different partitions #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch @anotherbugmaster 👍
|
anotherbugmaster
force-pushed
the
fix_arch_tests
branch
from
afeeafd
to
6c6d118
Compare
|
@menshikh-iv, all done. :) |
menshikh-iv
changed the title
|
Great job @anotherbugmaster 👍 |
VaiyeBe
pushed a commit
to VaiyeBe/gensim
that referenced
this pull request
Nov 26, 2017
…rtitions (piskvorky#1733) * Fix typo * Make `save_corpus` private * Annotate `bleicorpus.py` * Make __save_corpus weakly private * Fix _save_corpus[2] * Document bleicorpus in Numpy style * Fix tests on Arch Linux * Revert "Document bleicorpus in Numpy style" This reverts commit 04c2e61. * Revert "Fix _save_corpus[2]" This reverts commit 3b55037. * Revert "Make __save_corpus weakly private" This reverts commit 34bd9ef. * Revert "Annotate `bleicorpus.py`" This reverts commit 34cccfe. * Revert "Make `save_corpus` private" This reverts commit cde582e. * Revert "Fix typo" This reverts commit 3cc34ff. * Handle the multiple partitions case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are working on Arch Linux now. There was a problem with new
downloader.pymodule and tmpfs partition.