Fix the train method of TranslationMatrix #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix-word2vec-notebook Conflicts: gensim/test/test_word2vec.py
menshikh-iv
suggested changes
Jan 15, 2018
| @@ -393,6 +393,9 @@ def __init__(self, tagged_docs, source_lang_vec, target_lang_vec, random_state=N | |||
| self.random_state = utils.get_random_state(random_state) | |||
| self.translation_matrix = None | |||
|
|
|||
| if tagged_docs is not None: | |||
There was a problem hiding this comment.
Problem isn't fixed in train method (you continue to ignore passed parameter).
menshikh-iv
suggested changes
Jan 15, 2018
gensim/models/translation_matrix.py
Outdated
| def train(self, tagged_docs): | ||
| """Build the translation matrix that mapping from the source model's vector to target model's vector | ||
|
|
||
| Parameters | ||
| ---------- | ||
| tagged_docs : list of :class:`~gensim.models.doc2vec.TaggedDocument`, optional | ||
| THIS ARGUMENT WILL BE IGNORED. | ||
| tagged_docs : list of :class:`~gensim.models.doc2vec.TaggedDocument` |
There was a problem hiding this comment.
Need to add a description for this parameter, what is it.
|
Thanks @robotcator 👍 |
sj29-innovate
pushed a commit
to sj29-innovate/gensim
that referenced
this pull request
Feb 21, 2018
* fix the compatibility between python2 & 3 * require explicit corpus size, epochs for train() * make all train() calls use explicit count, epochs * add tests to make sure that ValueError is indeed thrown * update test * fix the word2vec's reset_from() * require explicit corpus size, epochs for train() * make all train() calls use explicit count, epochs * fix some error * fix test error * make tagged_docs optional * fix the train method * add comments for the translation matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make the tagged_doc parameter as optional, and fixed some docstring.