Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store images from README directly in repository. Fix #1849 #1861

Merged
merged 3 commits into from
Feb 6, 2018
Merged

Store images from README directly in repository. Fix #1849 #1861

merged 3 commits into from
Feb 6, 2018

Conversation

ibrahimsharaf
Copy link
Contributor

Issue (#1849)

@menshikh-iv
Copy link
Contributor

menshikh-iv commented Jan 29, 2018 •
edited
Loading

Thank you @ibrahimsharaf, can you make it bigger (same size as https://github.com/RaRe-Technologies/gensim#adopters, width=100)?

@menshikh-iv menshikh-iv changed the title Store images from README directly in repository Store images from README directly in repository. Fix #1849 Jan 29, 2018
@ibrahimsharaf
Copy link
Contributor Author

Hi @menshikh-iv, I already made them all width=100, should I make it 200?

@menshikh-iv
Copy link
Contributor

menshikh-iv commented Jan 29, 2018 •
edited
Loading

@ibrahimsharaf I see two problems:

  • Look at the rendered version of README.md, this doesn't look like width=100 (you can check it with "devtools" of your browser), README should look like current readme.
  • You have distorted the proportions of some of the logos, need to stay original proportions.

@menshikh-iv
Copy link
Contributor

Ping @ibrahimsharaf, how is going?

@ibrahimsharaf
Copy link
Contributor Author

Hi @menshikh-iv, I've been busy recently, will continue work on the PR by tomorrow.

@ibrahimsharaf
Copy link
Contributor Author

Hi @menshikh-iv, would you take a look?

@menshikh-iv
Copy link
Contributor

Hi @ibrahimsharaf, thanks, good work:+1:

@menshikh-iv menshikh-iv merged commit caed7d0 into piskvorky:develop Feb 6, 2018
@ibrahimsharaf ibrahimsharaf deleted the readme_images branch February 6, 2018 14:20
sj29-innovate pushed a commit to sj29-innovate/gensim that referenced this pull request Feb 21, 2018
@ibrahimsharaf @sj29-innovate
Store images from README.md directly in repository. Fix piskvorky#1849
85f84be 
 (piskvorky#1861)

* Add README images to repo

* Resize images

* Bigger images
@piskvorky piskvorky mentioned this pull request Apr 30, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ibrahimsharaf @menshikh-iv