Fix minor semantic issue in docs for phrases #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please fix |
|
@piskvorky fixed in 2d066d5, together with other minor corrections |
|
Nice, I appreciate that. Many of our open source contributors are not native speakers (myself included), so such corrections and clean-ups help a lot, even if minor! |
|
Glad to help! With that in mind, I'll see if I can find time to do more non-code "fixes" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The impact of the
thresholdparam is heavily influenced by the choice of the scoring function - the docs should reflect this (instead of saying that this hardly matters, wich means the opposite).It's a tiny change, but might prevent some confusion in future readers of the docs