Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix check for callbacks #2251

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Fix check for callbacks #2251

merged 2 commits into from
Jan 11, 2019

Conversation

allenyllee
Copy link
Contributor

Use any() method to check if there are any metric in self.metrics is a instance of (DiffMetric, ConvergenceMetric)

allenyllee and others added 2 commits November 1, 2018 21:15
@allenyllee
Fixes check for "any" metrics
46cf9cb 
Use `any()` method to check if there are any metric in `self.metrics` is a instance of `(DiffMetric, ConvergenceMetric)`
@menshikh-iv
Merge remote-tracking branch 'upstream/develop' into patch-1
349b0c5
@menshikh-iv
Copy link
Contributor

Thank you @allenyllee, nice catch, congratz with the first contribution 🥇

@menshikh-iv menshikh-iv changed the title Fixes check for "any" metrics Fix check for callbacks Jan 11, 2019
@menshikh-iv menshikh-iv merged commit 380b8bb into piskvorky:develop Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@allenyllee @menshikh-iv