Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extra list creation in utils.get_max_id #2254

Merged
merged 2 commits into from
Dec 11, 2018
Merged

Fix extra list creation in utils.get_max_id #2254

merged 2 commits into from
Dec 11, 2018

Conversation

horpto
Copy link
Contributor

@horpto horpto commented Nov 1, 2018

No description provided.

@piskvorky piskvorky requested review from piskvorky and removed request for piskvorky November 5, 2018 14:48
@menshikh-iv menshikh-iv changed the title Fix extra list creation in get_max_id Fix extra list creation in utils.get_max_id Dec 11, 2018
@menshikh-iv menshikh-iv merged commit 54e2164 into piskvorky:develop Dec 11, 2018
@menshikh-iv
Copy link
Contributor

Good, thank you @horpto, just interest: how did you find that?

@horpto
Copy link
Contributor Author

horpto commented Dec 12, 2018 •
edited
Loading

Good, thank you @horpto, just interest: how did you find that?

@menshikh-iv
I don't remember already. Or just looked at an utils module or maybe looked for what I can refactor in corpuses (save_corpus -> dict_from_corpus -> get_max_id).

@horpto horpto deleted the utils-get_max_id branch January 10, 2019 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@horpto @menshikh-iv