Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nmf bugfix #2466

Merged
merged 2 commits into from May 4, 2019

Conversation

Projects
None yet
2 participants
@mpenkov
Copy link
Collaborator

commented Apr 28, 2019

The logging bugs are blocking our gensim feedstock release on conda.

The divide-by-zero doesn't cause any test failures, but we should fix it anyway.

@mpenkov mpenkov added the bugfix label Apr 28, 2019

@mpenkov mpenkov requested a review from anotherbugmaster Apr 28, 2019

@mpenkov mpenkov self-assigned this Apr 28, 2019

@piskvorky

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

@mpenkov

This comment has been minimized.

Copy link
Collaborator Author

commented May 4, 2019

I'm gonna go ahead and merge this in the interest of time.

@mpenkov mpenkov merged commit 20ccabd into RaRe-Technologies:develop May 4, 2019

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mpenkov mpenkov deleted the mpenkov:nmf-bugfix branch May 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.