Document that preprocessing.strip_punctuation is limited to ASCII punctuation characters
#2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ASCII as qualification on `strip_punctuation` doc string. This is "option 1" fix for issue piskvorky#2962
piskvorky
requested changes
Sep 29, 2020
Code comment added linking to issue piskvorky#2962 as a reminder of enhancement possibilities.
Yes. I've done so. |
piskvorky
approved these changes
Sep 30, 2020
mpenkov
approved these changes
Jun 29, 2021
mpenkov
changed the title
|
Congrats on your first PR to gensim @sciatro 🥇 ! |
piskvorky
changed the title
preprocessing.strip_punctuation is limited to ASCII punctuation characters
|
Reminder to self to update the CHANGELOG entry before a release. The current entry makes it sound like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mitigates issue #2962 by documenting that the function's current behavior is limited to ASCII punctuation.
Issue #2962 includes discussion of approaches to expanding strip_punctuation's behavior to cover unicode punctuation. This PR includes no new functionality / does not implement any of the possibilities considered in the issue. This PR is option 1 of the 3 considered in #2962