Remove strip_punctuation2 alias of strip_punctuation #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re Issue 2961
Re Issue 2961, remove strip_punctuation alias strip_punctuation2 which makes a mess of docs
Re Issue 2961, remove use of strip_punctuation2 function which was an alias of strip_punctuation
piskvorky
approved these changes
Sep 30, 2020
mpenkov
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2961 noted that
parsing.preprocessing.strip_punctuationhad an aliasparsing.preprocessing.strip_punctuation2which made the docs a bit less clear and did not get much use. Discussion of the issue concluded:This PR does so. Fixes #2961.