Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize performance of Author-Topic model #2978

Merged
merged 5 commits into from
May 12, 2021
Merged

Optimize performance of Author-Topic model #2978

merged 5 commits into from
May 12, 2021

Conversation

horpto
Copy link
Contributor

@horpto horpto commented Oct 10, 2020

No description provided.

@jonaschn
Copy link
Contributor

@horpto Is there any performance gain? Did you benchmark this change?

@horpto
Copy link
Contributor Author

horpto commented Apr 15, 2021

@jonaschn well, i can make a some microbench with a few days.

@piskvorky piskvorky changed the title take out common part of expression in ATModel Optimize performance of Author-Topic model Apr 15, 2021
@piskvorky piskvorky requested a review from mpenkov April 15, 2021 11:41
@mpenkov
Copy link
Collaborator

mpenkov commented Apr 28, 2021

@horpto Are you able to share the benchmark results?

mpenkov
mpenkov approved these changes May 12, 2021
View reviewed changes
Copy link
Collaborator

@mpenkov mpenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark results would have been good, but the change makes sense, so the absence of the benchmarks shouldn't block this PR.

@mpenkov mpenkov merged commit 52281eb into piskvorky:develop May 12, 2021
@mpenkov
Copy link
Collaborator

mpenkov commented May 12, 2021

Thank you @horpto for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piskvorky piskvorky piskvorky approved these changes

@mpenkov mpenkov mpenkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@horpto @jonaschn @mpenkov @piskvorky