LsiModel: Only log top words that actually exist in the dictionary #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@piskvorky should I add any documentation or test cases? |
|
Thanks! Maybe add a code comment that links to #3090. So that future people reading the code are not confused or don't accidentally delete that code, thinking it's useless. |
In some pathological cases, we might try to log the top N words, even though we haven't seen N words yet. In these cases, we can just exit the loop early. Closes piskvorky#3090.
|
Ok, force-pushed a comment. Thanks for being so responsive 😄 |
In 8f8cb49, I added a check that checks val in self.id2word When testing, `id2word` is actually an instance of `FakeDict`, which doesn't implement `__contains__()` (so Python falls back to calling `__getitem__()`[1]). The tests didn't like this[2]. [1] https://docs.python.org/3.6/reference/datamodel.html#object.__contains__ [2] https://github.com/RaRe-Technologies/gensim/runs/2197137529
piskvorky
changed the title
piskvorky
approved these changes
Mar 31, 2021
|
@piskvorky anything else you need from me here? No rush, just trying to make sure it doesn't get lost in the shuffle 😄 |
|
Thanks, a reminder is definitely a good idea :) PR already approved by me; the next step is a review by @mpenkov, who will merge if all OK. |
|
Looks good to me! Thank you @kmurphy4 ! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some pathological cases, we might try to log the top N words, even
though we haven't seen N words yet. In these cases, we can just exit
the loop early.
Closes #3090.