Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FastText doc-comment example for build_vocab and train to use correct argument names #3227

Merged
merged 4 commits into from
Oct 24, 2021

Conversation

HLasse
Copy link
Contributor

@HLasse HLasse commented Sep 2, 2021

Some of the examples in the documentation for the FastText model are not runnable as they use the sentences argument which should be corpus_iterable instead.

@piskvorky piskvorky added bug Issue described a bug documentation Current issue related to documentation labels Sep 2, 2021
@piskvorky
Copy link
Owner

piskvorky commented Sep 2, 2021

Thanks! Is this the only place where sentences remained, could you have a look and fix them all please?

@HLasse
Copy link
Contributor Author

HLasse commented Sep 3, 2021

Looked through fasttext.py, word2vec.py, and doc2vec.py. Could only find the references to sentences already fixed in this PR :)

@piskvorky
Copy link
Owner

Great, thanks. @mpenkov once the wheel building is fixed, can you please re-run the CI & merge? Cheers.

@mpenkov mpenkov merged commit e5cb531 into piskvorky:develop Oct 24, 2021
@mpenkov
Copy link
Collaborator

mpenkov commented Oct 24, 2021

Merged. Thank you @HLasse !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue described a bug documentation Current issue related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants