[MRG] API for Static Topic for word in Vocabulary. #706
Conversation
bhargavvader
changed the title
bhargavvader
changed the title
|
Thanks. Can the output be in same format as |
|
Would that mean a tuple with that word and corresponding topic? |
|
@tmylk made it the same format as |
bhargavvader
changed the title
| @@ -905,6 +905,28 @@ def get_document_topics(self, bow, minimum_probability=None): | |||
| return [(topicid, topicvalue) for topicid, topicvalue in enumerate(topic_dist) | |||
| if topicvalue >= minimum_probability] | |||
|
|
|||
| def get_static_topic(self, word_id, minimum_probability=None): | |||
There was a problem hiding this comment.
Default minimum_probability=0 is most intuitive
There was a problem hiding this comment.
I disagree. 0.0 is a specific value to use, whereas None stands for "use default". Different semantics.
|
@tmylk , @piskvorky , could you please review? I've finished and wrote tests. |
| @@ -905,6 +905,28 @@ def get_document_topics(self, bow, minimum_probability=None): | |||
| return [(topicid, topicvalue) for topicid, topicvalue in enumerate(topic_dist) | |||
| if topicvalue >= minimum_probability] | |||
|
|
|||
| def get_static_topic(self, word_id, minimum_probability=None): | |||
| """ | |||
| Returns static topics for word in vocabulary. | |||
There was a problem hiding this comment.
Needs better docs -- what is a "static topic"?
|
The method name doesn't seem right; @cscorley any better ideas? Maybe |
|
@piskvorky , yeah |
|
Looks good, thanks @bhargavvader . I leave the final sanity checks & merge touches to @tmylk |
|
Just a note in the changelog and then ready to merge. |
|
@tmylk done! |
|
Yep, |
|
@tmylk when are you planning to release? This version is getting scarily bulky again. Does it make sense to release before the PyCon coding sprint, so people can work off a fresh version? |
@tmylk to complement the dynamic word document topic, this is a PR for static word topics.