LdaMallet Fixes #771
Merged
LdaMallet Fixes #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me... except still needs a comment explaining why the alias is there. And maybe a mention in the changelog, so we can deprecate the old name, gradually. |
|
Added comment, made change in changelog. |
This was referenced Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is with respect to #767 .
I removed the unnecessary log mentioning the variable assignment, and tried to add an alias by doing
self.word_topics = self.wordtopics = self.load_word_topics().Is that correct?
I also changed occurrences of
topntonum_wordsto keep it consistent throughout. #755 already did this, but leftprint_topicandshow_topicuntouched. It doesn't cause any problems but I thought I'd make it the same throughout.@tmylk , @piskvorky , please review.