Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests around encoding handling for various readers #145

Closed
mpenkov opened this issue Nov 20, 2017 · 0 comments
Closed

Add tests around encoding handling for various readers #145

mpenkov opened this issue Nov 20, 2017 · 0 comments

Comments

@mpenkov
Copy link
Collaborator

mpenkov commented Nov 20, 2017

smart_open supports a variety of reader protocols:

  • s3
  • hdfs
  • webhdfs
  • http
  • any others?

Currently, each of those implements its own logic for handling character encoding. This logic isn't being tested anywhere.

We should add tests to test that this logic works. In the future, we may refactor such that the encoding logic gets handled in a single place for all readers, so these tests should face the public API, as opposed to something internal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant