Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change VERSION to version.py #349

Merged
merged 3 commits into from Sep 11, 2019
Merged

Change VERSION to version.py #349

merged 3 commits into from Sep 11, 2019

Conversation

mpenkov
Copy link
Collaborator

@mpenkov mpenkov commented Sep 11, 2019 •
edited

@mpenkov
Copy link
Collaborator Author

mpenkov commented Sep 11, 2019

@rs-trevor I found the problem with your previous PR, and fixed it in this one. Thank you for your contribution.

@mpenkov mpenkov merged commit ac3db9b into piskvorky:master Sep 11, 2019
@mpenkov mpenkov deleted the versionpy branch September 11, 2019 05:59
@rs-trevor
Copy link

oh wow! Very generous of you. Thanks so much for the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

smart_open cannot be imported from within a zip file compile issues with pyinstaller
2 participants
@mpenkov @rs-trevor