Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test data in package via MANIFEST.in #401

Merged
merged 1 commit into from
Jan 5, 2020
Merged

Add test data in package via MANIFEST.in #401

merged 1 commit into from
Jan 5, 2020

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Dec 25, 2019

The tests are included in the sdist, but they fail without the data.

Also update docs filenames.

@jayvdb
MANIFEST.in: Add test data
cddbcca 
The tests are included in the sdist, but they fail without the data.

Also update docs.
mpenkov
mpenkov approved these changes Jan 5, 2020
View reviewed changes
Copy link
Collaborator

@mpenkov mpenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpenkov mpenkov changed the title MANIFEST.in: Add test data Add test data in package via MANIFEST.in Jan 5, 2020
@mpenkov mpenkov merged commit 52d300f into piskvorky:master Jan 5, 2020
@mpenkov
Copy link
Collaborator

mpenkov commented Jan 5, 2020

Merged. Thank you for your work! And congrats on your first contribution to smart_open 🥇

@mpenkov mpenkov mentioned this pull request Mar 4, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpenkov mpenkov mpenkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jayvdb @mpenkov