Correctly pass boto3 resource to writers #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for picking this up! Can you please add some tests? |
|
@mpenkov Would extending test_minio.py under the test directory to handle write request in addition to read request be okay or a separate test file is needed? |
|
I think the best way to test this would be a few new test cases in test_s3.py. You could wrap the resource in a Mock object and then check that the resource was correctly re-used by smart_open. Does that make sense? |
mpenkov
changed the title
|
I added the tests myself. Thank you for your contribution @jackluo923 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fixed bug where boto3 resource are ignored for object upload
Motivation