Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout support for http/https requests #594

Merged
merged 4 commits into from Mar 19, 2021

Conversation

dustymugs
Copy link
Contributor

Title

Add timeout support for http/https requests

Motivation

Requests supports timeouts and their own docs recommend setting a timeout for production use.

Timeouts

This is especially true in cloud envs (e.g. AWS Lambda) where you are charged by the millisecond and can only be so patient for an HTTP endpoint to respond.

Work in progress

If you're still working on your PR, include "WIP" in the title.
We'll skip reviewing it for the time being.
Once you're ready to review, remove the "WIP" from the title, and ping one of the maintainers (e.g. mpenkov).

Checklist

Before you create the PR, please make sure you have:

  • Picked a concise, informative and complete title
  • Clearly explained the motivation behind the PR
  • Linked to any existing issues that your PR will be solving
  • Included tests for any new functionality
  • Checked that all unit tests pass

@mpenkov mpenkov merged commit 6d5e8ff into piskvorky:develop Mar 19, 2021
@mpenkov
Copy link
Collaborator

mpenkov commented Mar 19, 2021

Thank you @dustymugs ! Congrats on your first contribution to smart_open!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants