Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UploadFailedError picklable #689

Merged

Conversation

birgerbr
Copy link
Contributor

Make UploadFailedError picklable

Motivation

The ray library is not able to handle unpicklable exceptions sufficiently, see ray-project/ray#21075 for a similar issue.

Tests

The PickleUploadFailedTest test case has been added to test_gcs.py.

Checklist

Before you create the PR, please make sure you have:

  • Picked a concise, informative and complete title
  • Clearly explained the motivation behind the PR
  • Linked to any existing issues that your PR will be solving
  • Included tests for any new functionality
  • Checked that all unit tests pass

@mpenkov
Copy link
Collaborator

mpenkov commented Apr 23, 2022

Hi, can you please make this PR editable for maintainers?

As a maintainer, I'd like to merge the most recent upstream into your PR, but need you to give me permission first.

@birgerbr
Copy link
Contributor Author

Hi, can you please make this PR editable for maintainers?

As a maintainer, I'd like to merge the most recent upstream into your PR, but need you to give me permission first.

I added you with write permission to https://github.com/Imerso3D/smart_open.
Is that sufficient?

@mpenkov
Copy link
Collaborator

mpenkov commented Apr 23, 2022

Yes, that's a little excessive (you can set it for individual PRs instead of the whole repo) but it will get the job done. Thanks.

@mpenkov mpenkov merged commit 7ddbbad into piskvorky:develop Apr 23, 2022
@birgerbr
Copy link
Contributor Author

Yes, that's a little excessive (you can set it for individual PRs instead of the whole repo) but it will get the job done. Thanks.

Thanks for the info. I did not know that. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants