Add FTPS support (#33) #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piskvorky
reviewed
Nov 19, 2022
ci_helpers/helpers.sh
Outdated
| --env HOME_DIR=/home/user \ | ||
| --env FTP_PORT=21 \ | ||
| --env FTPS_PORT=90 \ | ||
| rachitsharma2001/ftp_ftps |
There was a problem hiding this comment.
Running external docker images is scary, both from security and also maintenance perspective.
Any way to launch the FTP(S) server directly from Python here?
There was a problem hiding this comment.
Thank you for letting me know. I have removed the docker dependency and instead directly set up the ftp and ftps servers on ci using the vsftpd linux tool. Let me know if this looks good or if there is anything else I should add or change.
RachitSharma2001
force-pushed
the
ftps
branch
24 times, most recently
from
5650e6f
to
2c7a009
Compare
RachitSharma2001
force-pushed
the
ftps
branch
from
2c7a009
to
bef3c0f
Compare
piskvorky
approved these changes
Nov 19, 2022
|
Thanks for the quick resolution @RachitSharma2001. @mpenkov can you please review? |
It's simpler if we just run the whole script under sudo. The docstring helps our users. Also, we don't need read-text and write-text in FTP, that gets handled in a different part of smart_open.
since helpers.sh runs under sudo, it doesn't have access to the environment set in the workflow
looks like it _does_ get used after all
|
Thank you for your work @RachitSharma2001 ! |
mpenkov
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Support for reading and writing files directly to/from ftps (ftp with tls)
Motivation
I have previously added support ftp servers (without tls encryption). Now, to add more complete ftp functionality, I have added support for ftp+tls servers.
Tests
I have edited the ftp integration tests to run an ftp and ftps server on different ports and then test reading, writing, and appending to each of them. (specific integration test here, pull up ftp and ftps servers here).