Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Ability to add custom chains #1274

Closed
belg1o opened this issue Mar 2, 2023 · 38 comments
Closed

[Feature] Ability to add custom chains #1274

belg1o opened this issue Mar 2, 2023 · 38 comments

Comments

@belg1o
Copy link

belg1o commented Mar 2, 2023

What?

The ability to add custom chains is one feature that Rabby really lacks.

Why?

A lot of chains are being deployed and being able to add them ourselves before a Rabby implementation is crutial for developers and early adopters of chains. I do not want to have to switch back and forth between wallets constantly to be able to explore and use a chain that is not yet added.

Nice to have:

The ability to import chains via https://chainlist.org/

@fastackl
Copy link

fastackl commented Mar 3, 2023

Yup - product is awesome. I want to use it for testing contracts. That would require Rabby to allow me to add Goerli test network. Can't see to find a way to do that

@edmundedgar
Copy link

Just to add to this - I just tested Rabby after installing it a year or so ago and absolutely loved it, and was about to add it to my dapp's "recommended" screen that we show when you show up without a web3-enabled browser. (We originally recommended MetaMask but we removed that when they changed to a non-free license.) But then I went to test it with Goerli and that was missing and I couldn't add it, and some of the other chains we support were also missing.

This is a blocker for me and the only one - I'll definitely recommend this wallet once it's fixed.

@rummzink
Copy link

I look forward to remove Metamask from my browser and use Rabby as replacement. But it seems like lacking of the ability to add custom networks (i mean any network of user's choice) is preventing users from getting rid of Metamask.

@belg1o
Copy link
Author

belg1o commented May 18, 2023

@vvvvvv1vvvvvv

Hey guys. I've noticed you've been adding chain support over time, which is great but please allow us to add our own networks & chains with allowing us to define the RPCs.

This would solve all the following open requests:
#1379 #1360 #1369 #1212 #1066 #1049 #976 #974 #867 #826 #612 #353

@belg1o
Copy link
Author

belg1o commented May 18, 2023

@vvvvvv1vvvvvv

Hey guys, I've noticed you've been adding chain support over time, which is great but please allow us to add our own networks & chains with allowing us to define the RPCs.

This would solve all the following open requests: #1379 #1360 #1369 #1212 #1066 #1049 #976 #974 #867 #826 #612 #353

cc: @heisenberg-2077 @dmy147 @cs1707

@xHmmmmm
Copy link

xHmmmmm commented May 18, 2023

This functionality is so crucial for a complete wallet experience and yet Rabby's developers seem to overlook that particular topic strictly. While the concerns about quality of experience when using Rabby sound fair enough, the testnets aren't there for pleasure of use but to test things out and improve the network, and the idea of waiting for the developers to manually integrate a new chain every time one rolls out is just ridiculous and won't make the cut given number of new blockchains being created all the time.

Please add support for custom chains (maybe allow users to toggle this as an option in the settings). This is literally the only reason I stick to Metamask with its clunkiness and questionable ToS, instead of better in every other way Rabby. I suspect it's a deal-breaker for many potential users.

@Dereek69
Copy link

Agree with the other posts in this thread.
Having the ability to add custom chains is essential for a complete experience on a wallet. After seeing rabby being shared i download and had a really good time using it, until after the realization that it didnt support custom chains i was forced to freeze the extention and install metamask once again.
Its simply not possible for the developers of the projects to be up to date with every new chain and testnet deployed but users will need to interact with them.

Please make this a priority because its really badly needed

@radeksvarz
Copy link

+1 for prio
This is critical to use Rabby during trainings and demonstrations. We are stuck with MM for now :(

@latifrons
Copy link

+1
For normal users it is also important to switch between RPCs for the same chain id.
e.g. when playing with DeFi, users may switch to Flashbot protected RPC to prevent front-running, while for other txs they may switch to normal rpc (or infura rpc, alchemy rpc, etc) for fast confirmation.

and for devs both chain id and rpc need customization.

@stevyhacker
Copy link

+1 on this issue, it's very useful to have testnet support for devs and custom chain support for advanced users.

@dapp-whisperer
Copy link

+1, to testnet and custom RPC, this is the only reason I have MM still installed

@StayFoolisj
Copy link

+1 on having the ability to add testnets, quite surprised they've not prioritised this

@wsdt
Copy link

wsdt commented Jun 24, 2023

++++

@hdadr
Copy link

hdadr commented Jul 7, 2023

+1

@pripatelUK
Copy link

+++

@lucasregueiroo
Copy link

+1

1 similar comment
@aquaticone
Copy link

+1

@danyeah
Copy link

danyeah commented Jul 23, 2023

Any update on this?
Not having custom chains and testnets is a real pain.
Do you guys not use testnets at all???

@mdrlucky
Copy link

mdrlucky commented Jul 25, 2023

+1 without this feature, to be able to add testnets, users have to keep MM.
it majors risks for the users, and for you, you will lose market share once MM will issue news functionalities, add ins etc ..

@lucasregueiroo
Copy link

at least we got some testnets now lol

@dedosmedia
Copy link
Contributor

dedosmedia commented Aug 1, 2023

Sepolia Testnet please!

@vacekj
Copy link

vacekj commented Aug 7, 2023

@vvvvvv1vvvvvv Is there anything that I could do to expedite this feature? I'm more than happy to help move this forward.

@aspiers
Copy link

aspiers commented Aug 15, 2023

Oh wow, I was enjoying Rabby so much in these first few days and then I discovered this which is a total deal-breaker for me (I need Celo's Alfajores testnet). What a shame to stumble at the last hurdle after doing so amazingly well in all other respects! Given the overwhelming demand for this feature, it's a bit worrying that there hasn't been any comment on this issue from any Rabby devs. Are they aware of this? I guess I'll try to raise it on Discord.

@jurosh
Copy link

jurosh commented Aug 28, 2023

Seems like a deal-breaker to me too. As developers, we aren't only using public chains, and so without ability to add custom Chain (RPC, ChainId, Explorer) it's hard to test dApp with Rabby wallet.

Having ability to add custom chain might be needed also for L2 Chains of Polygon Supernets.

@trendespresso
Copy link

Any update on this?
Why can't we add custom chains???
At the very minimum, please add a "Localhost:8545" option where the ChainID is 31337.

@rkjdid
Copy link

rkjdid commented Nov 14, 2023

bumping this yes

@davidtacer
Copy link

+1

@berabuilder
Copy link

+1

@gpt420
Copy link

gpt420 commented Jan 8, 2024

++1

@radeksvarz
Copy link

Any update on this? Why can't we add custom chains??? At the very minimum, please add a "Localhost:8545" option where the ChainID is 31337.

I somehow understand the need for caution.

Thats why I propose a separate approach for dev localhost: #1417

@aspiers
Copy link

aspiers commented Jan 8, 2024

Apparently no response from the team here, so I sent this message on their Discord. It's clear that adding +1 comments here does nothing useful, so if you want this feature, please consider chiming in on Discord or trying to reach the Rabby team via other communication channels.

@kamikazebr
Copy link

Apparently no response from the team here, so I sent this message on their Discord. It's clear that adding +1 comments here does nothing useful, so if you want this feature, please consider chiming in on Discord or trying to reach the Rabby team via other communication channels.

Can we fork the project to add those?

@0xKurt
Copy link

0xKurt commented Mar 19, 2024

bump for interest

@eyooooo
Copy link

eyooooo commented Mar 27, 2024

please fckin add this or just keep up to date with it. op goerli shut down WEEKS ago and rabby still hasnt added op sepolia.

@vvvvvv1vvvvvv
Copy link
Member

You can add custom testnet in Rabby now, so the issue will be closed

@aspiers
Copy link

aspiers commented Mar 29, 2024

Seems like there is a misunderstanding or miscommunication here. The feature appears to be for custom testnets only, but the requested feature was for any custom chain (even mainnets).

image

@vvvvvv1vvvvvv
Copy link
Member

There is no limitation, you can also add any mainnet by this function but what we want to let you know is we will consider all custom network as testnet so there will no security features for these network

@aspiers
Copy link

aspiers commented Mar 29, 2024

Thanks that's good to know, but it's still confusing for the UI to present the option as "Custom Testnet" because this makes it look like custom mainnets cannot be added. The presence of the "Enable Testnets" toggle just above it makes it look like any custom network added via "Custom Testnet" will not be available if that toggle is disabled, which is counterproductive if the custom network added is actually a mainnet. So I suggest renaming the "Custom Testnet" option to "Custom network" or "Custom chain", or rethinking the design in some other way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests