Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to import smart accounts #2176

Open
metashx opened this issue Apr 4, 2024 · 0 comments
Open

Add option to import smart accounts #2176

metashx opened this issue Apr 4, 2024 · 0 comments

Comments

@metashx
Copy link

metashx commented Apr 4, 2024

Is Rabby interested in adding support for smart accounts?

Recent discussions on x (https://x.com/apoorvlathey/status/1775241280550756783?s=20, https://x.com/optimizoor/status/1775431530426638673?s=20) have made it clear this is a pain point.

The UX I'm imagining:

Step 1 Step 2
image image

(the input for owner in the Step 2 should be a dropdown of addresses already in the wallet)

Then, the smart account is then shown in your wallet like any other address, but Rabby will intelligently sign for the account using the address the user specifies when importing the smart account.

There will need to be some consideration on handling websites that don't support EIP-1271 so the user isn't confused when their signature fails. Maybe it's enough to check isValidSignature() when prompting the user for confirmation and show a clear message?

Users will also need to be aware the smart account will function differently from an EOA, but I assume someone importing one into their wallet knows the caveats. Is that a bad assumption?

I'm willing to help implement this if you're interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant