Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Code Identification Flawed Logic #8

Open
valkyrienyanko opened this issue Jul 31, 2021 · 4 comments
Open

Color Code Identification Flawed Logic #8

valkyrienyanko opened this issue Jul 31, 2021 · 4 comments
Labels
Console Console related Enhancement New feature or request Low Priority Not of primary focus

Comments

@valkyrienyanko
Copy link
Contributor

Say someone types the following message "&&&&&&&&&&" and sends it.

Nothing would get sent, the message would be transformed into "".

Another example, what if someone types "&Hello &yWorld"

It would become "Hello World" where "Hello" is white and "World" is yellow but the & would disappear. (The & should stay if there is no valid color code after the &)

This issue is low priority / fix for fun.

@valkyrienyanko valkyrienyanko added Enhancement New feature or request Help Wanted Extra attention is needed labels Jul 31, 2021
@valkyrienyanko valkyrienyanko self-assigned this Jul 31, 2021
@joshshep06
Copy link

So if there isn't a color code should there be an error message stating something like: "ERROR! Color Code not detected" With a guide on how to find a list of the color codes?

@valkyrienyanko
Copy link
Contributor Author

@joshshep06 Hello, thank you for showing an interest in this project.

If a message is sent with & but no color code following it, then it should be sent as is. For example, lets say the following message "&Foo &yBar" is sent. The message should be encoded as "&Foo Bar" where "&Foo " is white and "Bar" is yellow. Notice how the & with no color code after it stayed in the string.

No error message should be shown to the user as the user might have intended to put a & in the string without a color code following it. For example maybe they sent the following message to a client with the following command

whisper <player> <message>
whisper Bob apples & oranges are fruits

Maybe in the future there might be a helpful command that shows all the color codes in the console.

@joshshep06
Copy link

@valkyrienyanko ok thanks for clarifying.

A guide would be a great feature something like /help would be simple enough.

@valkyrienyanko
Copy link
Contributor Author

valkyrienyanko commented Jul 31, 2021

@valkyrienyanko ok thanks for clarifying.

A guide would be a great feature something like /help would be simple enough.

Something like help colors

@valkyrienyanko valkyrienyanko changed the title Color Code Identification Flawed Logic CONSOLE: Color Code Identification Flawed Logic Aug 1, 2021
@valkyrienyanko valkyrienyanko removed the Help Wanted Extra attention is needed label Aug 8, 2021
@valkyrienyanko valkyrienyanko removed their assignment Aug 10, 2021
@valkyrienyanko valkyrienyanko added the Console Console related label Aug 25, 2021
@valkyrienyanko valkyrienyanko changed the title CONSOLE: Color Code Identification Flawed Logic Color Code Identification Flawed Logic Aug 25, 2021
@valkyrienyanko valkyrienyanko added the Low Priority Not of primary focus label Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Console Console related Enhancement New feature or request Low Priority Not of primary focus
Projects
None yet
Development

No branches or pull requests

2 participants