Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all List<T> & Map<T, R> to ImmutableList<T> & ImmutableMap<T, R> for all Compose parameters. #89

Open
racka98 opened this issue Oct 31, 2022 · 0 comments
Labels
enhancement New feature or request investigating Bug is under investigation to get more details P1 High Priority

Comments

@racka98
Copy link
Collaborator

racka98 commented Oct 31, 2022

Describe the bug
List in Compose functions cause the composable to not be skippable. Means that they are re-evaluated every time the parent Composable recomposes. This can affect performance. Performance for screens that uses lists heavily like Tasks, Statistics and Goals can be affect when the lists change every time.

To Reproduce
No Applicable

Expected behavior
All Compose related models and parameters with List or Map<T, R> should be replaced with ImmutableList & ImmutableMap<T, R> respectively.

Additional context
All Composables that receive List or Map<T, R> do not pass lint checks and detekt with Twitter Compose Rules

@racka98 racka98 added enhancement New feature or request investigating Bug is under investigation to get more details P1 High Priority labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request investigating Bug is under investigation to get more details P1 High Priority
Projects
None yet
Development

No branches or pull requests

1 participant