hsakmt-dev should not install linux kernel headers #42
Conversation
Ignore requests to bind to invalid NUMA nodes. This affects only legacy applications (such as KFDTest) that allocate system memory as paged memory with a GPU node ID. Change-Id: I81e514af6d0c1ab2ed5229adeeca1fa0ab2a0685 Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com> (cherry picked from commit 54d664d)
hsakmt-dev should not install include/linux/* (currently just kfd_ioctl.h) as those are linux kernel headers provided by the linux kernel header packages (`linux-headers-*` on Debian/Ubuntu or `kernel-headers-*` on Red Hat / Fedora)
|
I'll apply this one, not PR#41. We do need kfd_ioctl.h for building libhsakmt. Depending on the latest kernel headers to build our library is something we're trying to avoid. But you're right, we don't need to install this header file as the clients of libhsakmt don't need it. |
|
Can I add a Signed-off-by: Craig Andrews <...> to your commits as certificate of origin? See also https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for. |
You absolutely can. If necessary, I can update any PRs/commits myself doing so, just let me know what's better/easier for you. |
|
I'll do it on my local branch, where I'm cherry-picking your patches and running them through our internal build/test and code review process. Thanks! |
|
@fxkamd Do you have any news? I'm eager to get this merged and stop having to carry/maintain the patch :) |
|
We missed the branching for 2.8, but it's slated to be included in 2.9. |
hsakmt-dev should not install include/linux/* (currently just kfd_ioctl.h) as those are linux kernel headers provided by the linux kernel header packages (
linux-headers-*on Debian/Ubuntu orkernel-headers-*on Red Hat / Fedora)