Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark new symbols in ROCm 5.7.0 as global #90

Closed
wants to merge 1 commit into from

Conversation

tpkessler
Copy link
Contributor

Fixes #89

@Mystro256
Copy link
Contributor

This is merged into 6.0, but looks like there's a new one:
hsaKmtGetAMDGPUDeviceHandle

I spoke to @kentrussell and I believe he said that they're merging this source code into rocr-runtime around the 6.1 release, so it won't be an issue soon.

@Mystro256
Copy link
Contributor

E.g. this worked for me:

diff --git a/src/libhsakmt.ver b/src/libhsakmt.ver
index 15c2916..c04cefe 100644
--- a/src/libhsakmt.ver
+++ b/src/libhsakmt.ver
@@ -81,6 +81,7 @@ hsaKmtWaitOnEvent_Ext;
 hsaKmtWaitOnMultipleEvents_Ext;
 hsaKmtReplaceAsanHeaderPage;
 hsaKmtReturnAsanHeaderPage;
+hsaKmtGetAMDGPUDeviceHandle;
 
 local: *;
 };

If this is really going away in 6.1, then there's probably no point to patch it.

@tpkessler
Copy link
Contributor Author

Thanks for the update, @Mystro256! I can confirm that hsa-rocr and rocminfo build fine with this patch. Given that this repo will become obsolete soon, I will close this PR.

@tpkessler tpkessler closed this Dec 20, 2023
@Mystro256
Copy link
Contributor

Hi, See a4d46eb, you can apply that to 6.0 to make it work.

@kentrussell merged it in for me :)
He also said it's a bit in the air when this repo will be obsoleted, but it will be one of the future 6.x releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing symbols in 5.7.0 release
2 participants