Skip to content

Commit

Permalink
Remove -h option from comgr-objdump
Browse files Browse the repository at this point in the history
The -h option (short for -headers) is a legal objdump option.
However registering this as an LLVM option by Comgr prevents other
LLVM tools or instances from registering a -h option in the same
process, which is an issue because -h is a common short form for
-help.

A long term solution will be to libraryize llvm-obj dump, and
call it in Comgr via an API instead of re-implementation, which
will eliminate the need for Comgr to register any LLVM options for
objdump.

Change-Id: Ieb1981aeb1826422647fd301c4827e2bfb370560
  • Loading branch information
lamb-j committed Jan 17, 2023
1 parent 48c682d commit 2d05f9e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lib/comgr/src/comgr-objdump.cpp
Expand Up @@ -175,9 +175,9 @@ cl::opt<bool> SectionHeaders("section-headers",
static cl::alias SectionHeadersShort("headers",
cl::desc("Alias for --section-headers"),
cl::aliasopt(SectionHeaders));
static cl::alias SectionHeadersShorter("h",
cl::desc("Alias for --section-headers"),
cl::aliasopt(SectionHeaders));
// The following option has been removed to avoid conflicts with
// other llvm tools/instances also attempting to register a -h option
// static cl::alias SectionHeadersShorter("h", ...)

cl::list<std::string>
FilterSections("section",
Expand Down

0 comments on commit 2d05f9e

Please sign in to comment.