-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cmake] Include more link libraries #88
Conversation
This is required to get dev-libs/rocm-opencl-driver-2.7.0 compiling for me on Gentoo I think it might be related to using -Wl,--as-needed in my link flags globally
Without this patch I see the following errors during compilation:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Btw, LLVM became c++14 a few weks ago, so use -std=c++14 now.
FWIW, LGTM as well. Thank you @FireBurn! |
Some time has passed (23 days) and this simple patch has not been merged yet. Please consider closing (merge into master or reject) this pull request today. Thanks. |
@kzhuravl, could you please merge it. Thanks! |
Done, thanks. |
This is required to get dev-libs/rocm-opencl-driver-2.7.0 compiling for me on Gentoo
I think it might be related to using -Wl,--as-needed in my link flags globally