Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Pytorch extension for your occupancy grid and volume rendering modules #6

Open
jingsenzhu opened this issue Apr 17, 2023 · 6 comments

Comments

@jingsenzhu
Copy link

Thank you again for your great work!

In your implementation of Permutohedral Encoding, you implement it as a Pytorch CUDA module so it's scalable and easy to migrate to other NeRF and SDF projects. However, I found that you implemented the Permuto SDF modules as pure CUDA classes requiring a lots of dependency libraries ,which I struggled in installing on my system without using a docker :( . Therefore, for code migration needs, I slightly modified your codes which removed most of the dependencies (of course, Pytorch and CUDA are still needed :) , making it into a installable Pytorch module.

If you agree, I'll release my modified codes on github. Thank you very much :D

@RaduAlexandru
Copy link
Owner

RaduAlexandru commented Apr 21, 2023

Hi there!

Thanks again for taking the time and for the feedback!

Currently I am also unhappy with how entangled the OccupancyGrid and VolumetricRendering is with the rest of the dependencies.
The whole codebase went throught a pretty big refactoring for the public release and I spent most of the time in getting the PermutohedralEncoding into it's own self-contained package. I'm not sure when I'll have time to clean up the rest of it so if you already performed the conversions and made it more modular, feel free to release it :)

Also if you need any help with the refactoring or with the code migration let me know.

@jingsenzhu
Copy link
Author

Hi, thanks for you feedback. I've release my version of refactored code on github HERE.
It would be better if you could link this and notify me if you have major revisions of your code, so that I can update my release accordingly.

@s-esposito
Copy link

Hi @jingsenzhu, thanks for your work! Does your refactored code still need PyTorch to be installed with CXX_ABI=1?

@jingsenzhu
Copy link
Author

Hi @jingsenzhu, thanks for your work! Does your refactored code still need PyTorch to be installed with CXX_ABI=1?

Hi @s-esposito , can you describe your problem in detail? My refactored code should be able to be installed with the default Pytorch from PIP or Conda.

@s-esposito
Copy link

Hi @jingsenzhu, thanks for the answer.
I was just asking because the official PermutoSDF requires PyTorch to be installed with CXX_ABI=1 (from README.md)

@jingsenzhu
Copy link
Author

Hi @jingsenzhu, thanks for the answer. I was just asking because the official PermutoSDF requires PyTorch to be installed with CXX_ABI=1 (from README.md)

I don't think my code has this requirement, for I've successfully run my code under a Pytorch directly installed from PIP without any other constraints.

Tell me if you meet other problems when you install my code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants