Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequent unlockTheBarn should return 429 too many requests but status code is always 200 #2

Open
RadwaSaleh opened this issue Mar 23, 2023 · 0 comments

Comments

@RadwaSaleh
Copy link
Owner

Description:

When requesting unlockTheBarn twice, the second response body is different and it indicates that the order (unlocking the barn) is not done because it's already unlocked.

Severity:

Low

Priority:

Medium

Steps to Reproduce:

Request the following request twice from postman:

URL: /api/USER_ID/barn-unlock
Method: POST
Auth: Bearer Token retrieved from getAccessToken in The_Coop_API.postman_collection.json

Expected Results

  1. First request returns 200 Ok with the following response body
    { "action": "barn-unlock", "success": true, "message": "You just unlocked your barn! Watch out for strangers!", "data": null }

  2. Second request returns 429 too many requests with the following body to follow best practices
    { "action": "barn-unlock", "success": true, "message": "The barn is already wide open! Let's throw a party!", "data": null }

Actual Results

Both requests respond with 200 Ok with different response message.

@RadwaSaleh RadwaSaleh changed the title unlockTheBarn should return 429 too many requests but status code is 200 Frequent unlockTheBarn should return 429 too many requests but status code is 200 Mar 23, 2023
@RadwaSaleh RadwaSaleh changed the title Frequent unlockTheBarn should return 429 too many requests but status code is 200 Frequent unlockTheBarn should return 429 too many requests but status code is always 200 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant