Discussion about Stack tabs support #472
Replies: 2 comments 3 replies
-
|
Failure -> Can't reproduce any of this on a mock vault. Probably because of point ^1 as the mock vault doesn't have enough query and load. Will try again. |
Beta Was this translation helpful? Give feedback.
-
|
great investigative work! With insider version I could see that Sliding panes is deprecated and will be removed in favor of stack tabs feature, so I will focus on #435 While its fixed, I just add some error handler with the search, but I think its not related. It has to do with refreshing the table after filtering. With the new stack tabs it doesn't even load well |
Beta Was this translation helpful? Give feedback.
-
|
Okay, the problem its related with the overflow css property. Table and stack shares the same overflow and this cause the crash... Screen.Recording.2022-10-06.at.20.50.16.movThe tables need its own overflow property in case of belong to one. But this fact requires some refactor. Once this theory is confirmed I will let you know |
Beta Was this translation helpful? Give feedback.
-
|
Confirmed! Screen.Recording.2022-10-06.at.21.18.51.movThis is a css job (not my special strong point), so do not expect a fix soon =( |
Beta Was this translation helpful? Give feedback.
-
|
At last we know what the problem is, that's all what matters for now 😄 |
Beta Was this translation helpful? Give feedback.
-
I literally after trying to find problem for hours on #469 . I give up, but with ongoing debugging here's what i understand that would just be a theory for now, that's why opened a discussions rather then replying on the initial bug report, as really these are just my speculations.
The react table rendering is not optimized while running an intense query in combination be it tags, dataview or whatever data as a source to dbfolder {especially in sliding panes plugin, which have this on their readme "The current API of this repo targets Obsidian v0.10.9.")}. That's a bit misleading because the plugin last updated on September 2022. I am confused about sliding pane, whether on what api version it is targeting. As from [Bug]: Obsidian Crashing due to db folder, unknown reason. #469 many others have indicated that they are having problems with sliding panes as the root cause, and I myself was one of them. But when tried with a mock vault things tend to look different.
like for example: I ran a mock vault, everything was fine with sliding panes. Perhaps having one or two files on two databases works just fine, but when your are opening that in concurrent with large query then things lead to a crash.
What i am about to write, is happening right at this moment in my obsidian, most of the time you resize the database pane by whatever means, like for example:
then obsidian is struck, and this happened right at this moment i am writing, i just opened my calender plugin pane, which i am sure most of you have been using, and yeah obsidian is struck. (calender plugin has nothing to do with the issue, but resizing of tables does.)
Note -> You would definitely don't see any of this when using 5 to 6 files with a single db and opening them concurrently, that time things are as smooth as butter, But combine pages with n+ rows in a database, querying and opening multiple dbs of the same nature, would end up in these issues.
Conclusion (on basis of speculations ofcourse) :- rendering engine needs to scale and load handling should be done in a more crash resilient way.
that's all for hours of debugging. 😆 need some more hours to come back and write what happened.
in a few days, i am planning to release my vault of academia as opensource, then you can replicate these issues @RafaelGB. But ofcourse cleaning my vault, preparing it for public would take time. You know what it's like, right.
Beta Was this translation helpful? Give feedback.
All reactions