Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: empty space at the bottom when filter bar is hidden #654

Closed
2 tasks done
imeed166 opened this issue Dec 8, 2022 · 2 comments
Closed
2 tasks done

[Bug]: empty space at the bottom when filter bar is hidden #654

imeed166 opened this issue Dec 8, 2022 · 2 comments
Assignees
Labels
Visual Visual problem of the application

Comments

@imeed166
Copy link
Collaborator

imeed166 commented Dec 8, 2022

Contact Details

No response

What happened?

When enabling the filter bar, the database fills all the pane's height, but when disabling the filter bar there is an empty space not filled by the database. Can you make it fill all the pane height, even if the filter bar is hidden?

Screen.Recording.2022-12-08.at.9.59.24.PM.mov

What platform were you using?

Desktop

Version of the plugin

3.0.1

Relevant log output

No response

Are you using the latest version of the plugin in your Obsidian vault?

  • I have verified that I am on the latest version

Are you check if there is a similar issue?

  • I have verified that there are not similar issues
@imeed166 imeed166 added bug Something isn't working triage Issue not tagged yet. talking to the user labels Dec 8, 2022
@RafaelGB
Copy link
Owner

RafaelGB commented Dec 8, 2022

the window has a 92% - 8% to support mobile pagination. We cN try to improve the design for sure

@RafaelGB RafaelGB added Visual Visual problem of the application and removed bug Something isn't working triage Issue not tagged yet. talking to the user labels Dec 8, 2022
@RafaelGB
Copy link
Owner

I have to maintain that empty space in order to support the footer menus, but the % of scroll content will be adjusted in function of the resolution of your monitor now

.database-plugin__scroll-container {
  will-change: transform;
  width: 100%;
  height: 98%;
  scroll-margin-bottom: 1rem;
}

@media only screen and (max-height: 1440px) {
  .database-plugin__scroll-container {
    will-change: transform;
    width: 100%;
    height: 95%;
  }
}

@media only screen and (max-height: 1024px) {
  .database-plugin__scroll-container {
    will-change: transform;
    width: 100%;
    height: 92%;
  }
}

@media only screen and (max-height: 768px) {
  .database-plugin__scroll-container {
    will-change: transform;
    width: 100%;
    height: 85%;
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Visual Visual problem of the application
Projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants