Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Lists in a Text property column now have brackets inserted around them, which breaks links in the list #686

Closed
2 tasks done
Mazarkus opened this issue Dec 23, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Mazarkus
Copy link

Contact Details

lecardinal@gmail.com

What happened?

It looks like version 3.1.0 now adds brackets when a property value is in a list, and it breaks linking when those properties are links to another page. Previously when a column type is "text", it would just take the text by itself and everything in the list of links would work

error2

error1

What platform were you using?

Desktop

Version of the plugin

3.1

Relevant log output

No response

Are you using the latest version of the plugin in your Obsidian vault?

  • I have verified that I am on the latest version

Are you check if there is a similar issue?

  • I have verified that there are not similar issues
@Mazarkus Mazarkus added bug Something isn't working triage Issue not tagged yet. talking to the user labels Dec 23, 2022
@RafaelGB
Copy link
Owner

Oh I see, we won’t consider the inline arrays with links. Will be fixed with next versions. Thanks for the report!

@RafaelGB RafaelGB removed the triage Issue not tagged yet. talking to the user label Dec 23, 2022
@RafaelGB
Copy link
Owner

As a better aproximation

// Is a list
if (/(^\[{1})([^\[]{1}.*[^\]]{1})(\]{1})$/.test(newValue)) {
      // Remove brackets
      newValue = newValue.replaceAll(/(^\[{1})([^\[]{1}.*[^\]]{1})(\]{1})$/, "$2");
     // Another things               
  }

@Mazarkus
Copy link
Author

Thanks for the rapid feedback! Really enjoy this plugin, I switched from notion and not having databases was my main hesitation

@RafaelGB
Copy link
Owner

I am glad that you enjoy it =)

Fixed and also with an improvement

Screen.Recording.2022-12-23.at.22.10.58.mov

@Mazarkus
Copy link
Author

Mazarkus commented Jan 1, 2023

With the most recent fix, the lists are a little buggy still. If I format my list the way I originally posted, it adds a blank entry in the display.

Example setting in YAML:

aliases:
- alias 1
- alias 2

Example visual display

-
- alias 1
- alias 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants