Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Changes not persisting #77

Closed
arminta7 opened this issue May 30, 2022 · 12 comments
Closed

[BUG] Changes not persisting #77

arminta7 opened this issue May 30, 2022 · 12 comments
Assignees
Labels
bug Something isn't working

Comments

@arminta7
Copy link

Having issues again with my edits not persisting. For example, adding a column, changing the name, populating values within the column, etc. If I navigate and return to the db page, all changes are reset to default.

Desktop (please complete the following information):

  • OS: Mac OS Monterey 12.3.1
@RafaelGB
Copy link
Owner

This bug worries me a lot. Happens only when including new rows?

@RafaelGB RafaelGB added the triage Issue not tagged yet. talking to the user label May 31, 2022
@RafaelGB RafaelGB changed the title Changes not persisting [BUG] Changes not persisting May 31, 2022
@arminta7
Copy link
Author

When adding new columns. Maybe sometimes when editing existing columns? It's really hard for me to tell if it happens with other edits, I'll need to pay attention more closely. But it seems, for me, that most of the time my edits don't save.

@RafaelGB
Copy link
Owner

RafaelGB commented May 31, 2022

could you share your database yaml? (the markdown mode) I will try to reproduce it

@arminta7
Copy link
Author

This?

<%%
name: pillars database
description:
columns:
file:
key: file
input: markdown
label: File
accessor: file
isMetadata: true
skipPersist: false
csvCandidate: true
isInline: false
config:
modified:
key: modified
input: calendar_time
label: Modified
accessor: modified
isMetadata: true
skipPersist: false
csvCandidate: true
isInline: false
config:
Type:
input: text
key: Type
accessor: Type
label: Type
position: 0
config:
enable_media_view: true
media_width: 100
media_height: 100
isInline: true
Projects:
input: text
accessor: Projects
key: Projects
label: Projects
position: 2
config:
isInline: true
media_height: 100
media_width: 100
enable_media_view: false
Status:
input: text
accessor: Status
key: Status
label: Status
position: 3
config:
isInline: true
media_height: 100
media_width: 100
enable_media_view: false
Testing:
input: text
accessor: Testing
key: Testing
label: Testing
position: 4
config:
isInline: true
media_height: 100
media_width: 100
enable_media_view: false
config:
enable_show_state: false
remove_field_when_delete_column: false
group_folder_column:
show_metadata_created: false
show_metadata_modified: true
source_data: current_folder
source_form_result:
filters:
%%>

@RafaelGB
Copy link
Owner

RafaelGB commented May 31, 2022

exactly! thanks, I will test it

@RafaelGB
Copy link
Owner

with a new vault and your exact configuration all is fine after some test

Screen.Recording.2022-05-31.at.16.47.03.mov

Which version of dbfolder are you using?

@arminta7
Copy link
Author

Version 1.6

This happens with every db folder database that I have tried, not just the one I sent.

Could it be related to the issue of new fields not being created? #80 ? It may be that what I'm usually editing is a new column that doesn't exist in my files yet or inputting a value into a column for a page that doesn't have an inline field yet.

@arminta7
Copy link
Author

No, it isn't just that. Here's what I just tried:

Added the field "Test" to two files.
Added a new column "Test" in their db
Went to the settings to specify inline
Exited settings and the column name was set back to "New Column 7" (didn't save name)

Renamed column to "Test".
Filled out text values for the two Test field in the 2 pages I created the Test field in.
(I have both pages open and the value was not changed when entering these values)
Exited the db folder page (navigated to a different page).
Went back to the db folder page.
Column was reset to "New Column 7"
All entered values were erased.
No values in the pages with "Test" field.

@RafaelGB
Copy link
Owner

I found the first problem of renaming. When you close column settings, the table is restarted. The edited name of the column is not shared well with the settings part and its overwritten again with old one.

After fix that, I will try to reproduce the second part. Thanks for the testing as always @arminta7

@RafaelGB RafaelGB added bug Something isn't working and removed triage Issue not tagged yet. talking to the user labels May 31, 2022
@RafaelGB RafaelGB added this to 🥶 backlog in Obsidian database plugin Roadmap via automation May 31, 2022
@RafaelGB RafaelGB moved this from 🥶 backlog to 👩‍💻👨‍💻 In progress in Obsidian database plugin Roadmap May 31, 2022
@RafaelGB
Copy link
Owner

RafaelGB commented Jun 1, 2022

with 1.6.1 version the first one is fixed, working on an stable version. The official release comes soon

@RafaelGB RafaelGB self-assigned this Jun 2, 2022
@RafaelGB
Copy link
Owner

RafaelGB commented Jun 3, 2022

This still happening with 1.6.2? Working with lot of bug fixes on 1.6.3 but this is not reproduced in my tests

@arminta7
Copy link
Author

arminta7 commented Jun 4, 2022

Yes, this seems much better!! Nice work 👏

@arminta7 arminta7 closed this as completed Jun 4, 2022
Obsidian database plugin Roadmap automation moved this from 👩‍💻👨‍💻 In progress to ✅ Done Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

2 participants