Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Admin/Media.php crop options #59

Closed
iamwebrocker opened this issue Mar 27, 2020 · 0 comments
Closed

Typo in Admin/Media.php crop options #59

iamwebrocker opened this issue Mar 27, 2020 · 0 comments

Comments

@iamwebrocker
Copy link
Contributor

Hi,

in

https://github.com/Rahe/Simple-image-sizes/blob/master/classes/Admin/Media.php#L407

$crop = '[ "' . $crop[0] . '", "' . $crop[1] . '")';

should be

$crop = '[ "' . $crop[0] . '", "' . $crop[1] . '"]';

Found this while looking why the crops will always be center/center, even with other positions like center/top in a WP 5.3.2 install.

Sadly changing the above doesn't fix this behavior, but I think it is a typo, nonetheless. :)

cheers,
Tom

@Rahe Rahe closed this as completed in fac3714 Nov 9, 2020
Rahe added a commit that referenced this issue Nov 9, 2020
Change paranthesis in Media.php, fixes #59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant