Skip to content
This repository has been archived by the owner on Jul 31, 2021. It is now read-only.

Project Creation, New File>New Menu #48

Closed
wants to merge 38 commits into from
Closed

Project Creation, New File>New Menu #48

wants to merge 38 commits into from

Conversation

Cy4Shot
Copy link
Contributor

@Cy4Shot Cy4Shot commented Feb 11, 2021

yes, another one, ill stop spamming once i get github to work/
no, this isnt actually 31 commits, its 10 ish.

What is in this PR?

  • A temporary banner for the website
  • The final File>New menu we decided on in #brainstorm
  • Forge Version Helper which allows you to get all kinds of information about forge versions.
  • The Project creation dialog

Copy link
Contributor

@jojo2357 jojo2357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whats going in in RailroadTopMenu so I wont approve. Besides its probably all getting chunked anyway

@Cy4Shot
Copy link
Contributor Author

Cy4Shot commented Feb 11, 2021

Not sure whats going in in RailroadTopMenu so I wont approve. Besides its probably all getting chunked anyway

yeah, we discussed this with steven and some others on discord. should be the most intuitive layout we can make.

@PugzAreCute
Copy link
Contributor

w8 what is the diff between rebase & merge

@jojo2357
Copy link
Contributor

https://www.atlassian.com/git/tutorials/merging-vs-rebasing

Basically when you pr and your commits get squashed into one, it registers that you have commits (the ones just merged) that arent on upstream/master so a merge just adds them all together but rebase will look at upstream and based on the changes after where your fork branches off, either apply your extra commits or disregard them

@Cy4Shot
Copy link
Contributor Author

Cy4Shot commented Feb 12, 2021

so, can we merge this?

@Cy4Shot Cy4Shot changed the title Another PR so that i can rebase my branch Project Creation, New File>New Menu Feb 12, 2021
@Cy4Shot
Copy link
Contributor Author

Cy4Shot commented Feb 12, 2021

ok, i fixed some of the bad code, this should be a lot better now

@Cy4Shot
Copy link
Contributor Author

Cy4Shot commented Feb 13, 2021

can some1 review this?

Copy link
Contributor

@PugzAreCute PugzAreCute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, Stable

Copy link
Member

@saksham4106 saksham4106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me

@Cy4Shot Cy4Shot closed this Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants