Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure whats going in in RailroadTopMenu so I wont approve. Besides its probably all getting chunked anyway
yeah, we discussed this with steven and some others on discord. should be the most intuitive layout we can make. |
w8 what is the diff between rebase & merge |
https://www.atlassian.com/git/tutorials/merging-vs-rebasing Basically when you pr and your commits get squashed into one, it registers that you have commits (the ones just merged) that arent on upstream/master so a merge just adds them all together but rebase will look at upstream and based on the changes after where your fork branches off, either apply your extra commits or disregard them |
so, can we merge this? |
ok, i fixed some of the bad code, this should be a lot better now |
can some1 review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, Stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good to me
yes, another one, ill stop spamming once i get github to work/
no, this isnt actually 31 commits, its 10 ish.
What is in this PR?