Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass is breaking on @extend “.bg-faded” #273

Open
obromios opened this issue Nov 21, 2017 · 4 comments
Open

Sass is breaking on @extend “.bg-faded” #273

obromios opened this issue Nov 21, 2017 · 4 comments

Comments

@obromios
Copy link

On using rails-composer, with the rails-devise-pundit option, I had the following error

Sass::SyntaxError - ".authform form" failed to @extend ".bg-faded".
The selector ".bg-faded" was not found.
Use "@extend .bg-faded !optional" if the extend should be able to fail.

This was fixed using this SO answer. However, I do not understand why it happened in the first place.

Chris

@golddiga
Copy link

golddiga commented Feb 8, 2018

change @extend .bg-faded; to @extend .bg-light;

answer found here

@obromios
Copy link
Author

obromios commented Feb 8, 2018

goldiga, the answer you refer to is the same one I cite in my question. The issue is why is rails-composer generating code that needs to be manually fixed.

@DanielKehoe
Copy link
Member

DanielKehoe commented Feb 9, 2018

The .bg-faded was changed to .bg-light in Bootstrap v4 Beta 1 in July 2017. I haven't been tracking the changes in Bootstrap v4 (I'm not using Bootstrap v4) which is why Rails Composer was generating code that had to be manually fixed (with later versions of Bootstrap). Thanks for catching this and bringing it to my attention. I've updated the rails_layout gem to fix this.

You can check if this is resolved now but I am getting errors building the rails-devise-pundit example application with Rails 5.2 and Ruby 2.5. Probably some more issues to report if you can identify them.

@obromios
Copy link
Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants