Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php8 #2221

Open
krchavdarov opened this issue May 16, 2023 · 16 comments
Open

php8 #2221

krchavdarov opened this issue May 16, 2023 · 16 comments

Comments

@krchavdarov
Copy link

krchavdarov commented May 16, 2023

Hello, dear,
i update my php to 8.2.4 and get this error:
Deprecated: Creation of dynamic property RainLoop\Actions::$bIsAjax is deprecated in /web/rainloop/rainloop/v/1.17.0/app/libraries/RainLoop/Actions.php on line 164

Deprecated: Creation of dynamic property RainLoop\Plugins\Manager::$aAjaxFilters is deprecated in /web/rainloop/rainloop/v/1.17.0/app/libraries/RainLoop/Plugins/Manager.php on line 82
can you help me?

@Russell-Lahti
Copy link

I had the same. I had to move to php 8.1 to get it functional.

@vuonglequoc
Copy link

I fixed like this: vuonglequoc@3059554
And it's seem work well now.

Idea: just declare these class properties.

@blyamur
Copy link

blyamur commented Jun 3, 2023

I fixed like this: vuonglequoc@3059554 And it's seem work well now.

Idea: just declare these class properties.

This method did not help me. I declared
private $aAjaxFilters;
private $bIsAjax;
but the error didn't go away. I even restarted the services. What did I do wrong?
The option to downgrade the PHP version is working, but so-so

@vuonglequoc
Copy link

I fixed like this: vuonglequoc@3059554 And it's seem work well now.
Idea: just declare these class properties.

This method did not help me. I declared private $aAjaxFilters; private $bIsAjax; but the error didn't go away. I even restarted the services. What did I do wrong? The option to downgrade the PHP version is working, but so-so

What is your new error?

(I'm using PHP 8.2.6 + RainLoop 1.17.0 + this fix)

@blyamur
Copy link

blyamur commented Jun 5, 2023

The error is not new, but the same

Deprecated: Creation of dynamic property RainLoop\Actions::$bIsAjax is deprecated in /www/..../rainloop/v/1.17.0/app/libraries/RainLoop/Actions.php on line 164

Deprecated: Creation of dynamic property RainLoop\Plugins\Manager::$aAjaxFilters is deprecated in /www/..../rainloop/v/1.17.0/app/libraries/RainLoop/Plugins/Manager.php on line 82

Version RainLoop 1.17.0
Version PHP | 8.2.4
and the fixes I gave above
If I downgrade the PHP version to 8.1, then everything is fine.
This is not critical, of course, but))

@mean-cj
Copy link

mean-cj commented Jun 13, 2023

fast fix bug v1.7.0

sed -ie 's/private $sLogginedUser;/private $sLogginedUser;\n        private $bResponseBufferChanged;/' \
    /var/www/html/rainloop/rainloop/v/1.17.0/app/libraries/MailSo/Imap/ImapClient.php

sed -ie 's/private $sUpdateAuthToken;/private $sUpdateAuthToken;\n        private $bIsAjax;/' \
    /var/www/html/rainloop/rainloop/v/1.17.0/app/libraries/RainLoop/Actions.php

sed -ie 's/private $aAdditionalParts;/private $aAdditionalParts;\n        private $aAjaxFilters;/' \
    /var/www/html/rainloop/rainloop/v/1.17.0/app/libraries/RainLoop/Plugins/Manager.php

@krchavdarov
Copy link
Author

fast fix bug v1.7.0

sed -ie 's/private $sLogginedUser;/private $sLogginedUser;\n        private $bResponseBufferChanged;/' \
    /var/www/html/rainloop/rainloop/v/1.17.0/app/libraries/MailSo/Imap/ImapClient.php

sed -ie 's/private $sUpdateAuthToken;/private $sUpdateAuthToken;\n        private $bIsAjax;/' \
    /var/www/html/rainloop/rainloop/v/1.17.0/app/libraries/RainLoop/Actions.php

sed -ie 's/private $aAdditionalParts;/private $aAdditionalParts;\n        private $aAjaxFilters;/' \
    /var/www/html/rainloop/rainloop/v/1.17.0/app/libraries/RainLoop/Plugins/Manager.php

after your help, now i get:
Fatal error: Cannot redeclare MailSo\Imap\ImapClient::$bResponseBufferChanged in /web/rainloop/rainloop/v/1.17.0/app/libraries/MailSo/Imap/ImapClient.php on line 85

@mean-cj
Copy link

mean-cj commented Jun 13, 2023

@krchavdarov
/web/rainloop/rainloop/v/1.17.0/app/libraries/MailSo/Imap/ImapClient.php
your file already have defined "private $bResponseBufferChanged;

@mean-cj
Copy link

mean-cj commented Jun 15, 2023

PHP 8.2.5 , Rainloop 1.17.0

Please note.

Cannot open the attachments files example .xls (excel) .docx (word) , .pdf ... more.
after download file from rainloop file have injection error code to header file.

b>Deprecated</b>:  Creation of dynamic property MailSo\Base\StreamWrappers\Literal::$context is deprecated in <b>/var/www/html/rainloop/rainloop/v/1.17.0/app/libraries/MailSo/Base/StreamWrappers/Literal.php</b> on line <b>65</b><br />

<b>Deprecated</b>:  Creation of dynamic property MailSo\Base\StreamWrappers\Binary::$context is deprecated in <b>/var/www/html/rainloop/rainloop/v/1.17.0/app/libraries/MailSo/Base/StreamWrappers/Binary.php</b> on line <b>242</b><br />

image

@krchavdarov
Copy link
Author

@krchavdarov /web/rainloop/rainloop/v/1.17.0/app/libraries/MailSo/Imap/ImapClient.php your file already have defined "private $bResponseBufferChanged;

I don't understand what I should do or am I wrong?

@mean-cj
Copy link

mean-cj commented Jun 15, 2023

@krchavdarov
Sorry i note other error on php 8

@krchavdarov
Copy link
Author

@krchavdarov Sorry i note other error on php 8

what do you think about my mistake?

Fatal error: Cannot redeclare MailSo\Imap\ImapClient::$bResponseBufferChanged in /web/rainloop/rainloop/v/1.17.0/app/libraries/MailSo/Imap/ImapClient.php on line 85

@mean-cj
Copy link

mean-cj commented Jun 15, 2023

Hi @krchavdarov

Please follow this update.
#2224

@krchavdarov
Copy link
Author

i have tried many things and it doesn't work with php8
I recommend everyone to go to https://snappymail.eu/

@xcodrer
Copy link

xcodrer commented Jul 27, 2023

\rainloop\rainloop\v\1.17.0\app\libraries\RainLoop\Actions.php
\rainloop\rainloop\v\1.17.0\app\libraries\RainLoop\Plugins\Manager.php

#[\AllowDynamicProperties]
//Above Class

\rainloop\rainloop\v\1.17.0\app\libraries\MailSo\Imap\BodyStructure.php
413
if (0 === strlen((string) $sResult))
{
$aParts = $this->SearchAttachmentsParts();
foreach ($aParts as $oPart)
{
if (0 === \strlen((string) $sResult))

\rainloop\rainloop\v\1.17.0\app\libraries\MailSo\Base\Utils.php
177 (string) $sEncoding)
658 if (0 < \strlen((string) $sIncomingCharset))
1642 (string) $sUtfString)

\rainloop\rainloop\v\1.17.0\app\libraries\Imagine\Image\Metadata\MetadataBag.php
on line 43,52,61,69,76,88.... Above Function
#[\ReturnTypeWillChange]

\rainloop\rainloop\v\1.17.0\app\libraries\MailSo\Base\StreamWrappers\Binary.php
\rainloop\rainloop\v\1.17.0\app\libraries\MailSo\Base\StreamWrappers\Literal.php
\rainloop\rainloop\v\1.17.0\app\libraries\MailSo\Log\Logger.php
\rainloop\rainloop\v\1.17.0\app\libraries\Imagine\Exception\RuntimeException.php
\rainloop\rainloop\v\1.17.0\app\libraries\MailSo\Imap\Exceptions\NegativeResponseException.php

#[\AllowDynamicProperties]

\rainloop\rainloop\v\1.17.0\app\libraries\lessphp\lessc.inc.php
#[\AllowDynamicProperties]
line 3205,if (@preg_match
line 1331, (int)...
protected function coerceColor($value) {
switch($value[0]) {
case 'color': return $value;
case 'raw_color':
$c = array("color", 0, 0, 0);
$colorStr = substr($value[1], 1);
(int) $num = hexdec($colorStr);
(int) $width = strlen($colorStr) == 3 ? 16 : 256;

			for ($i = 3; $i > 0; $i--) { // 3 2 1
				(int) $t = $num % $width;
				$num /= $width;

				$c[$i] = $t * (256/$width) + $t * floor(16/$width);
			}

			return $c;

\rainloop\rainloop\v\1.17.0\app\libraries\RainLoop\Providers\Version.php
#[\AllowDynamicProperties]

@niwid888
Copy link

me too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants