Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve card-slider/Carousel on home page using third party libraries or UI change. #2

Closed
Raj-m01 opened this issue Oct 2, 2022 · 11 comments · Fixed by #3
Closed
Assignees
Labels

Comments

@Raj-m01
Copy link
Owner

Raj-m01 commented Oct 2, 2022

third party libraries for reference :
https://github.com/jama5262/CarouselView
https://github.com/IslamKhSh/CardSlider
https://github.com/Ramotion/cardslider-android

@deysouparno
Copy link

hi, is this issue accepted for hacktoberfest 2022 ? I would like to contribute to it

@Raj-m01
Copy link
Owner Author

Raj-m01 commented Oct 2, 2022

hi, is this issue accepted for hacktoberfest 2022 ? I would like to contribute to it

Hey, yes it is hacktoberfest accepted.

@rishabhknowss
Copy link

please assign me the task , i would really appreciate!

@deysouparno
Copy link

can you please provide the API_KEY needed for gradle build

@Raj-m01
Copy link
Owner Author

Raj-m01 commented Oct 4, 2022

can you please provide the API_KEY needed for gradle build

Sure, u can generate ur own api key from here : https://newsapi.org/
Or
U can use mine if needed
"5a3e054de1834138a2fbc4a75ee69053"

@deysouparno
Copy link

can you please confirm if we have access to push code in this repo

@Raj-m01
Copy link
Owner Author

Raj-m01 commented Oct 6, 2022

Hey you can follow steps mentioned in contributing.md to pull request your work. Then I will review and merge your code in main repo.

@deysouparno
Copy link

image

it is showing permission denied during pushing new branch

@Raj-m01
Copy link
Owner Author

Raj-m01 commented Oct 6, 2022

can you share full git bash log, pls

@Raj-m01
Copy link
Owner Author

Raj-m01 commented Oct 6, 2022

Can you check if you have added origin to correct repo ( you may have mistakenly added remote origin to my repo, instead of forked repo)
git remote add origin <LINK_OF_FORKED_REPO_IN_YOUR_ACCOUNT>

@deysouparno
Copy link

ooh got it

@Raj-m01 Raj-m01 linked a pull request Oct 9, 2022 that will close this issue
@Raj-m01 Raj-m01 closed this as completed Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants