Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep whatever is needed from raku/doc .htaccess #84

Closed
coke opened this issue Feb 8, 2023 · 5 comments
Closed

Keep whatever is needed from raku/doc .htaccess #84

coke opened this issue Feb 8, 2023 · 5 comments

Comments

@coke
Copy link
Contributor

coke commented Feb 8, 2023

https://github.com/Raku/doc/blob/f20a83e0b9d43285910a3196073d4d433b7fdbb0/html/.htaccess is the last version from the raku/doc repository. Has support tracking some renames and top level URLS

@coke coke added this to the Go Live milestone Feb 8, 2023
@finanalyst
Copy link
Collaborator

Doesn't .htaccess assume Apache as the web facing software? I do not know whether NGINX respects .htaccess.

@coke
Copy link
Contributor Author

coke commented Feb 8, 2023

We need to support the config elements regardless of the implementation.

@finanalyst
Copy link
Collaborator

I have been looking at some of the rules in .htacess There is not much consistency to them.

In fact, given the discussion about naming files using a consistent standard % escaping, the renaming rules would create a loop, eg. one rule seems to rename names from an escaped form to a $Accent form.

So before we spend a lot of time trying to get a set of NGINX rules to match these .htacess rules, it may be worth clarifying what is being mapped and to what.

I think we should consider changing the milestone on this issue from GoLive to Cleanup

@coke coke modified the milestones: Go Live, Cleanup Feb 17, 2023
@coke
Copy link
Contributor Author

coke commented Feb 17, 2023

Moved to Cleanup - while we have as an ideal "break no links", I'm OK with some breakage of rewrites as we spin up the new site, and we can use the logging after the fact to find 404s and ensure those are fixed.

@finanalyst
Copy link
Collaborator

This issue seems to be addressed.
If inward links generate 404s, we can check to see if the .htaccess has something we missed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants