Skip to content

Commit

Permalink
Don't test this fragment
Browse files Browse the repository at this point in the history 
Once we run this code, every test file after this point fails.

Closes #3391
  • Loading branch information
@coke
coke committed Jul 28, 2020
1 parent acf784f commit c3a2332
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions doc/Type/Metamodel/DefiniteHOW.pod6
View file
Expand Up @@ -4,6 +4,7 @@
=SUBTITLE Metaobject for type definiteness
=for code :skip-test<breaks the metamodel>
class Metamodel::DefiniteHOW
does Metamodel::Documenting
{ }
Expand Down

4 comments on commit c3a2332

@JJ
Copy link
Contributor

@JJ JJ commented on c3a2332 Jul 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it break the metamodel? Is it because it's incorrect?

@coke
Copy link
Collaborator Author

@coke coke commented on c3a2332 Jul 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rakudo's Metamodel::DefiniteHOW has several methods that are needed for a functioning implementation . This sample has none. This sort of breakage is extremely rare, so easier to not include it than to rewrite xt/exam* to wrap it even more.

@JJ
Copy link
Contributor

@JJ JJ commented on c3a2332 Jul 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that it might happen with many different roles as long as they are pure abstract ones. So I wonder if in this case we should check only that it's syntactically correct, not that it's actual working code. In the case of methods, it's not a real implementation, there's no block behind. How come these not be the same?

@coke
Copy link
Collaborator Author

@coke coke commented on c3a2332 Aug 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are Going through hoops, doing the minimum to ensure it’s valid code only. Please feel free to open a ticket to track this, but it’s not imo worth the time to implement

Please sign in to comment.