Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/tmp files don't get cleaned up properly #1973

Closed
Kaiepi opened this issue Apr 29, 2018 · 9 comments
Closed

/tmp files don't get cleaned up properly #1973

Kaiepi opened this issue Apr 29, 2018 · 9 comments
Assignees
Labels
bug Error of some kind, from a typo to errors in the examples.

Comments

@Kaiepi
Copy link
Collaborator

Kaiepi commented Apr 29, 2018

The problem

  • app.pl leaves behind two files in /tmp after running
  • htmlify.pl6 leaves behind several thousand files if perl is killed before it finishes. Your OS may not be able to clear /tmp on boot when this happens because there are too many files to pass to rm

Suggestions

  • I'm working on a fix for the first issue
  • Maybe a tmp dir should be made in the repo when running htmlify.pl6 and removed after the script has finished. This would make removing files on SIGINT/SIGTERM a matter of just catching the signal and removing the entire directory
@coke
Copy link
Collaborator

coke commented Apr 29, 2018

The change was recently made it to htmlify And it’s relying on the module to remove the files when it’s done we can easily remove them as we go. I’ll Put that back tomorrow.

@coke coke self-assigned this Apr 29, 2018
@zoffixznet
Copy link
Contributor

app.pl leaves behind two files in /tmp after running

That part has been fixed in 65f77f515a

@zoffixznet
Copy link
Contributor

zoffixznet commented Apr 29, 2018

I'm working on a fix for the first issue

Oh, sorry, missed that part. If your fixed is better, just toss mine out.

@Kaiepi
Copy link
Collaborator Author

Kaiepi commented Apr 29, 2018

If your fixed is better, just toss mine out.

Yours is better. I was unlinking them after copying instead

@coke coke closed this as completed in 2b5cbcb Apr 29, 2018
@coke coke reopened this Apr 29, 2018
@coke
Copy link
Collaborator

coke commented Apr 29, 2018

That commit was all comments; if uncommented, the unlink causes the build to break. (another version with closing the handle before the unlink also breaks the build.)

@JJ
Copy link
Contributor

JJ commented May 5, 2018

So how's this going now? I'm kinda of confused. app.pl deletes its files, htmlify.p6 does not.

@coke
Copy link
Collaborator

coke commented May 5, 2018

... there were two complaints. one is fixed; the other is not. You can see my attempt in the commits above that had to be backed out because they broke the build.

@JJ JJ added build labels May 14, 2018
@JJ
Copy link
Contributor

JJ commented Jul 8, 2018

Maybe someone can take a look at this?

@JJ JJ added the bug Error of some kind, from a typo to errors in the examples. label Jan 2, 2019
@JJ
Copy link
Contributor

JJ commented May 6, 2019

Ref #1823

@JJ JJ closed this as completed in e9f3a9d Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Error of some kind, from a typo to errors in the examples.
Projects
None yet
Development

No branches or pull requests

5 participants
@JJ @coke @zoffixznet @Kaiepi and others