You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure this is the best, even performance-wise or security-wise. Not to mention that this indexing, despite taking place in the same repo as the general indexing to generate the page, is totally independent and untested (since it's in the script).
It's probably a good idea to think about refactoring this part of the repo, which could happen pretty much at the same time as the Big Split #2542 @azawawi also mentions the size of the file as a problem, and also other problems with indexing.
The text was updated successfully, but these errors were encountered:
JJ
added
the
meta
RFCs, general discussion, writing style, repository organization, etc.
label
Jan 18, 2019
The problem
p6doc stores the index as Perl6 code: https://github.com/perl6/doc/blob/master/bin/p6doc#L193 It EVALs it back when it loads it; it does that every time it's run.
Suggestions
I'm not sure this is the best, even performance-wise or security-wise. Not to mention that this indexing, despite taking place in the same repo as the general indexing to generate the page, is totally independent and untested (since it's in the script).
It's probably a good idea to think about refactoring this part of the repo, which could happen pretty much at the same time as the Big Split #2542
@azawawi also mentions the size of the file as a problem, and also other problems with indexing.
The text was updated successfully, but these errors were encountered: