Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p6doc index and running Perl 6 code #2574

Closed
JJ opened this issue Jan 18, 2019 · 1 comment
Closed

p6doc index and running Perl 6 code #2574

JJ opened this issue Jan 18, 2019 · 1 comment
Labels
meta RFCs, general discussion, writing style, repository organization, etc.

Comments

@JJ
Copy link
Contributor

JJ commented Jan 18, 2019

The problem

p6doc stores the index as Perl6 code: https://github.com/perl6/doc/blob/master/bin/p6doc#L193 It EVALs it back when it loads it; it does that every time it's run.

Suggestions

I'm not sure this is the best, even performance-wise or security-wise. Not to mention that this indexing, despite taking place in the same repo as the general indexing to generate the page, is totally independent and untested (since it's in the script).
It's probably a good idea to think about refactoring this part of the repo, which could happen pretty much at the same time as the Big Split #2542
@azawawi also mentions the size of the file as a problem, and also other problems with indexing.

@JJ JJ added the meta RFCs, general discussion, writing style, repository organization, etc. label Jan 18, 2019
@JJ JJ mentioned this issue Jan 18, 2019
@coke
Copy link
Collaborator

coke commented Mar 13, 2021

p6doc is no longer a part of this repository; it is now called rakudoc and is part of http://github.com/raku/rakudoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta RFCs, general discussion, writing style, repository organization, etc.
Projects
None yet
Development

No branches or pull requests

2 participants