Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] JVM build needs a couple of fixes. #589

Closed
vrurg opened this issue Dec 9, 2019 · 2 comments
Closed

[WIP] JVM build needs a couple of fixes. #589

vrurg opened this issue Dec 9, 2019 · 2 comments
Assignees
@vrurg

Comments

@vrurg
Copy link
Contributor

vrurg commented Dec 9, 2019

  • Dependency on runtime .java files.
  • configure_jars shall be moved from NQP::Configure in nqp-configure submodule to NQP::Configure::NQP.

This task just an anchor for WIP.
@vrurg vrurg self-assigned this Dec 9, 2019
@vrurg vrurg mentioned this issue Dec 9, 2019
Merged
@pmurias
Copy link
Contributor

pmurias commented Dec 9, 2019

The problem is that nqp-j uses gen/jvm/sshare/runtime/nqp-runtime.jar which is copied from nqp-runtime.jar but does not depend on it. So when a java file is changed and recompiled nqp-j still uses the old runtime from before recompile.

@vrurg vrurg mentioned this issue Dec 12, 2019
Merged
@vrurg
Copy link
Contributor Author

vrurg commented Dec 13, 2019

Closing via #590 and #591

@vrurg vrurg closed this as completed Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrurg vrurg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pmurias @vrurg