Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cool down blink flashes really fast #765

Closed
4 tasks done
Dag0d opened this issue Jan 4, 2021 · 5 comments
Closed
4 tasks done

cool down blink flashes really fast #765

Dag0d opened this issue Jan 4, 2021 · 5 comments

Comments

@Dag0d
Copy link

Dag0d commented Jan 4, 2021

This is a Feature Request

  • I have

    • Searched previous issues
    • This is in this firmware, not vendor "offical" firmware
    • This is not a bug in the vendor bootloader (aka DFU)
    • I have checked this is not already covered in the docs in /Documentation
  • What is the current behavior?
    Since the last release the cool down blink flashes really fast, way faster than before.
    With 2.12 it was WAY slower IMO even too slow.
    I think something in the middle would be the best

  • What is the expected behavior?
    Blinking slower

  • Steps to reproduce the bug:*
    enable cool down blinking

  • What is the motivation / use case for changing the behavior?
    Better readability if the blinking is a bit slower

  • What are you running:

On the idle screen, you can hold the settings button and it will show you the firmware & PCB version.
If using a USB-C supply please note model number

  • Firmware Version: 2.13 and I also tried a freshly compiled firmware
  • PCB Version: 2 (TS100)
  • Power Supply (Voltage and Current Rating) : 12v DC and 20v DC
@Firebie
Copy link

Firebie commented Jan 4, 2021

-					if (!(systemSettings.coolingTempBlink && (xTaskGetTickCount() % 250 < 160)))
+					if (!(systemSettings.coolingTempBlink && (xTaskGetTickCount() % 270 < 160)))

@discip
Copy link
Collaborator

discip commented Jan 4, 2021

@Firebie
Are you planning to create a PR?

@Dag0d
Copy link
Author

Dag0d commented Jan 4, 2021

Now as I know where to find that setting I can take care of the PR @discip

@discip
Copy link
Collaborator

discip commented Jan 4, 2021

Nice!

@Ralim
Copy link
Owner

Ralim commented Jan 4, 2021

Thanks guys for getting the PR ready overnight 🤟🏼

@Ralim Ralim closed this as completed Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants