Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with compact=true query string param #21

Open
limscoder opened this issue Aug 30, 2016 · 3 comments
Open

Doesn't work with compact=true query string param #21

limscoder opened this issue Aug 30, 2016 · 3 comments

Comments

@limscoder
Copy link

Request fails when specifying compact=true in query string.

@krmorse
Copy link
Contributor

krmorse commented Sep 15, 2016

Does it explode? Or just not fully hydrate all the results?

@limscoder
Copy link
Author

it blows up when checking for errors, since the errors and warnings arrays aren't included in the response if they are empty when compact=true. That's as far as it gets, so there maybe other issues

@krmorse
Copy link
Contributor

krmorse commented Sep 16, 2016

Cool, thanks for the update. That's the first issue for sure. Once that easy fix is applied we'll still need to add the hydrating code. But it seems like there are already good examples of that implemented in both Ext4 and Churro, so shouldn't be too hard...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants